Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add way to force SDK Init in a background thread #3376

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brustolin
Copy link
Contributor

Tests for Unreal, I will write the description later if it works.

#skip_changelog

Copy link

github-actions bot commented Nov 3, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add way to force SDK Init in a background thread ([#3376](https://github.com/getsentry/sentry-cocoa/pull/3376))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 279244d

Copy link

github-actions bot commented Nov 3, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.58 ms 1254.14 ms 8.56 ms
Size 22.85 KiB 411.93 KiB 389.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a176fc4 1251.52 ms 1259.14 ms 7.62 ms
df2986b 1227.45 ms 1244.35 ms 16.90 ms
257c2a9 1239.52 ms 1251.08 ms 11.56 ms
9fa25c2 1211.88 ms 1228.36 ms 16.48 ms
23e2db5 1240.96 ms 1253.86 ms 12.90 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms
6943de0 1215.83 ms 1253.22 ms 37.39 ms
fd6a31c 1190.43 ms 1218.78 ms 28.35 ms
98cca71 1227.43 ms 1239.22 ms 11.79 ms
62c15d4 1231.80 ms 1248.86 ms 17.06 ms

App size

Revision Plain With Sentry Diff
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
df2986b 22.85 KiB 406.89 KiB 384.04 KiB
257c2a9 20.76 KiB 401.36 KiB 380.60 KiB
9fa25c2 22.85 KiB 407.44 KiB 384.59 KiB
23e2db5 20.76 KiB 434.97 KiB 414.21 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
62c15d4 22.85 KiB 411.14 KiB 388.29 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants