Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric-stats): Fix metric stats outcomes for global metrics endpoint #3612

Merged
merged 2 commits into from
May 17, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented May 16, 2024

Addresses an open TODO where the global metrics endpoint didn't log metric_stats correctly.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner May 16, 2024 14:18
@Dav1dde Dav1dde self-assigned this May 16, 2024
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM, but I assume we still have the issue of double counting metadata in case we split buckets right?

@Dav1dde
Copy link
Member Author

Dav1dde commented May 16, 2024

@iambriccardo no, this was fixed with #3609 and #3592

@iambriccardo
Copy link
Member

@iambriccardo no, this was fixed with #3609 and #3592

Thanks!

@Dav1dde Dav1dde force-pushed the dav1d/batch-metric-outcomes branch from d765643 to ed54f9d Compare May 16, 2024 15:14
@Dav1dde Dav1dde merged commit 4ba2e8c into master May 17, 2024
22 checks passed
@Dav1dde Dav1dde deleted the dav1d/batch-metric-outcomes branch May 17, 2024 09:27
@Dav1dde Dav1dde mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants