feat(quotas): Add statsd data category #2526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// This data dategory is not defined to "count", today it only exists to turn off ingestion | ||
| /// for clients without metrics functionality. | ||
| Statsd = 14, | ||
| // | ||
| // IMPORTANT: After adding a new entry to DataCategory, go to the `relay-cabi` subfolder and run |
There was a problem hiding this comment.
Should we update cabi?
jjbayer
requested changes
Sep 22, 2023
| @@ -108,6 +113,7 @@ impl DataCategory { | |||
| Self::Monitor => "monitor", | |||
| Self::Span => "span", | |||
| Self::MonitorSeat => "monitor_seat", | |||
| Self::Statsd => "statsd", | |||
There was a problem hiding this comment.
Please also add the reverse mapping to from_name().
This is easy to miss, we should probably have a macro for it or use serde as the TODO says.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the used
statsdcategory.