ref(server): Do not cache envelope summary #2380
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
viglia
pushed a commit
that referenced
this pull request
Aug 4, 2023
…ng (#2383) Updating the envelope summary during envelope processing is currently a no-go, because recomputing the summary will miss the event item, which is taken from the envelope before processing. #2380 contains an attempt to remove caching of the envelope summary entirely. As a quick fix, this PR provides a partial update function. #skip-changelog
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
@jjbayer 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently keep a cached envelope summary on
ManagedEnvelope, which is not updated after the event item has been popped from the envelope for processing.This has the advantage that the summary still "contains" an event while it has been temporarily removed from the envelope, but it causes the problem that we cannot update it during processing without "losing" the event for the purpose of outcome reporting.
This PR attempts to remove all caching of the envelope summary, while still reporting correct outcomes for events.