Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git references for Cypress on CI #6143

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gabrieldutra
Copy link
Member

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Initially just testing, currently Cypress references are not going right from Github actions to Cypress Dashboard:

Screenshot 2023-07-02 at 14 34 24

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@gabrieldutra gabrieldutra changed the title Fetch all git history for Cypress on CI Fix git references for Cypress on CI Jul 2, 2023
@justinclift
Copy link
Member

Ahhhh. Is this the thing you mentioned the other day, where it would be good to have a clickable link somewhere in the GitHub Actions output that takes people to the Cypress Cloud output for that run? 😄

@gabrieldutra
Copy link
Member Author

Ahhhh. Is this the thing you mentioned the other day, where it would be good to have a clickable link somewhere in the GitHub Actions output that takes people to the Cypress Cloud output for that run? 😄

Yup, as soon as I fix it, Cypress Cloud will be back adding a "Check" to the PRs, which will mirror frontend-e2e-tests. I already found the issue, now I just need to pass the right variables :)

@justinclift
Copy link
Member

Awesome. 😄

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@guidopetri guidopetri added the CI label Jul 6, 2023
@justinclift
Copy link
Member

@gabrieldutra Looking at the screenshot above, is that a before or after screenshot?

I'm not sure what I'm looking at there, and am uncertain how to check the change/result of this PR after GitHub Actions runs.

@gabrieldutra
Copy link
Member Author

gabrieldutra commented Jul 8, 2023

@justinclift that's before migrating to GitHub actions. I still need to finish this PR (thus left it as Draft).

Pushed already last weekend, because I wanted to confirm that's what was missing

@justinclift
Copy link
Member

Cool, no worries. 😄

@guidopetri
Copy link
Collaborator

@gabrieldutra hey, any plans for finishing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants