Panorama: Add more feature about application instances #7624
+624
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YHallouard
force-pushed
the
feat/panorama_add_more_feature_about_application_instances
branch
3 times, most recently
from
8c91f4d
to
690aa9e
Compare
bblommers
requested changes
Apr 29, 2024
YHallouard
force-pushed
the
feat/panorama_add_more_feature_about_application_instances
branch
from
690aa9e
to
5f3e433
Compare
YHallouard
force-pushed
the
feat/panorama_add_more_feature_about_application_instances
branch
from
5f3e433
to
e4f0cc3
Compare
Hi @bblommers, tests are running well on my computer, I don't really understand why it is failing on CI |
bblommers
reviewed
May 19, 2024
| @mock_aws | ||
| def test_describe_application_instance() -> None: | ||
| # Given | ||
| panorama_client = boto3.client("panorama") |
There was a problem hiding this comment.
Suggested change
| panorama_client = boto3.client("panorama") | |
| panorama_client = boto3.client("panorama", "eu-west-1") |
We assume that the ARN starts with arn:aws:panorama:eu-west-1.. - but that is only the case if the region is set to eu-west-1. If the region is not explicitly configured, our CI assumes it is set in us-east-1, which results in a different ARN.
This will need to be changed in the other tests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.