Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate .editorconfig config, typo, sample code and grammar #1793

Open
wants to merge 2 commits into
base: 2nd-ed
Choose a base branch
from

Conversation

dev-itsheng
Copy link

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

Specifically quoting these guidelines regarding typos:

Typos?

Please don't worry about minor text typos. These will almost certainly be caught during the editing process.

If you're going to submit a PR for typo fixes, please be measured in doing so by collecting several small changes into a single PR (in separate commits). Or, just don't even worry about them for now, because we'll get to them later. I promise.


Please type "I already searched for this issue":

I already searched for this issue

Edition: (pull requests not accepted for previous editions) 2

Book Title:

Chapter: 1 & 2 & A & 4 & 5

Section Title: many

Topic:


I found an issue of sample code, but found that has been pointed in #1770, so I didn't fix.

@getify
Copy link
Owner

getify commented May 7, 2022

👀

@getify
Copy link
Owner

getify commented May 10, 2022

The changes to the markup around "NOTE" elements is unnecessary.

@dev-itsheng
Copy link
Author

The changes to the markup around "NOTE" elements is unnecessary.

When I modified the text before, it triggered the editor's Markdown table formatting, which caused changes around NOTE:.

The amendments to that section have been withdrawn.

@getify getify force-pushed the 2nd-ed branch 5 times, most recently from 23d8b7b to e909d38 Compare July 16, 2022 14:49
@getify getify force-pushed the 2nd-ed branch 3 times, most recently from 29c2978 to 667c741 Compare August 3, 2022 14:27
@getify getify force-pushed the 2nd-ed branch 6 times, most recently from ec72a23 to 976d472 Compare August 24, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants