Avoid returning deep copies with pandas 3.0 (with Copy-on-Write) #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has caused some dev failures related to CRS management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding some deep copies in case of pandas >= 3.0. Starting with pandas 3.0, most methods on a DataFrame (like rename or (re)set_index) will not return a hard copy of the data, but only a shallow copy (protected by Copy-on-Write, to ensure it still behaves as a copy).
We can follow that new behaviour in our own methods, so checking for a few cases where right now we always do a
copy()of self before adjusting and returning it.