Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose greedy colouring scheme from mapclassify #3025

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expose greedy colouring scheme from mapclassify #3025

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa6042
fix: issue 2818 , checking if scheme=='greedy'
kshitizfrompali Sep 22, 2023
de96046
Update plotting.py
kshitizfrompali Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions geopandas/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,9 +774,12 @@ def plot_dataframe(
if "k" not in classification_kwds:
classification_kwds["k"] = k

binning = mapclassify.classify(
np.asarray(values[~nan_idx]), scheme, **classification_kwds
)
if scheme == "greedy":
binning = mapclassify.classify(
np.asarray(values[~nan_idx]), scheme, **classification_kwds
)
else:
raise ValueError("Scheme is not greedy")
# set categorical to True for creating the legend
categorical = True
if legend_kwds is not None and "labels" in legend_kwds:
Expand Down