Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better patching #491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better patching #491

wants to merge 2 commits into from
+57 −9

Conversation

HJfod
Copy link
Member

@HJfod HJfod commented Feb 5, 2024 •
edited

Deprecates the existing Mod::patch API and adds platform-specific patching APIs. Reasoning is that since patching is inherently unportable, this reminds modders better that they need to also work out the correct patch for other platforms.

Unresolved questions

  • Implement platform-specific APIs
  • Add warning to Mod::patch
  • Should the functions issue a warning if you try to call them on another platform?
  • Should Mod::patch be removed completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@HJfod