Reexport geos/geozero/gdal/proj crates #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give some context about why we should do this? Presumably this is to simplify version resolving when a third party user is also using these crates, but a user will still have to be alert whenever we bump one of these versions. If a user wants whatever version is compatible with geoarrow-rs, why not set We use lots of dependencies... why stop at these four? Are we going to re-export every arrow dependency as well? (to be clear, this is devil's advocate; I'm inclined to not re-export any crate) |
|
I think it's convenient for users that reexporting same ecosystem crates. For example, datafusion reexports arrow/parquet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.