Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hard!
In particular I hit that there are multiple traits needed potentially:
Coord
: this would be similar to thearrow2
Offset
trait, and would be simple, describing whether it's XY, XYZ, etc. Maybe this would also have some knowledge of whether it's interleaved/separated, but that's uncertain.CoordBuffer
: I started with this, until I realized that I'd also need a mutable version of this. And we'd need some interaction betweenCoordBuffer
and someMutableCoordBuffer
trait. Not sure exactly how that would work.In contrast to
Offset
, which is used as a generic in bothOffsetsBuffer<O>
and the mutableOffsets<O>
, there are multiple ways to store the coords for the coord buffer. In particular, separated and interleaved coords aren't just generic over a single type, but their internal storage is different too. So you'd really need a generic for the coord buffer, and maybe another for the coord?Closes #127