sys-kernel/linux-firmware: compress firmwares via copy-firmware.sh #37213
Conversation
|
Note that I didn't ported all changes to live ebuild, only those that touches passing options to copy-firmware.sh |
Pull Request assignmentSubmitter: @puleglot sys-kernel/linux-firmware: Linked bugsBugs linked: 934537 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2024-06-19 08:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
puleglot
force-pushed
the
linux-firmware-compress
branch
from
9130007
to
13e0c10
Compare
Pull request CI reportReport generated at: 2024-06-19 08:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Currently we only skip compression of AMD microcode, but we should skip it for all files labeled as RawFile in WHENCE. copy-firmware.sh got support for compressing firmware files at some point and it does it right. A notable consequence of this change is that saved config now contains file names with compression extension. Closes: https://bugs.gentoo.org/934537 Signed-off-by: Alexander Tsoy <[email protected]>
puleglot
force-pushed
the
linux-firmware-compress
branch
from
13e0c10
to
b880333
Compare
Pull request CI reportReport generated at: 2024-06-19 09:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Do you know if there is a reason why it wasn't done like this originally in: https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-kernel/linux-firmware?id=12113f5d57730f8c36d3df433ec7f1606519e360 ? |
Because upstream added support for this later: |
|
nevermind, it's clear enough |
|
Is it normal to do a new commit like this so we can't see the diff ? |
The revision bump is required since the effective list of files excluded from compressing is changed. |
Currently we only skip compression of AMD microcode, but we should skip it for all files labeled as RawFile in WHENCE. copy-firmware.sh got support for compressing firmware files at some point and it does it right.
A notable consequence of this change is that saved config now contains file names with compression extension.
Closes: https://bugs.gentoo.org/934537
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.