[demo] Add the PortraitWindow #1287
Conversation
|
Please move the portrait controls, so it will look horizontally centered. It also takes away even more game space. Maybe it would be better if we added it over the right bottom side, which is full of placeholder buttons anyway. And using much smaller portraits, since they don't do anything anyway. |
|
Ok, will do. If we're going to move the placeholder buttons, would it be a good idea to add the OptionsWindow now for them? To the left side of the screen. |
|
No, that would just take more space. I kinda like the pst/iwd2 approach here. We can move them in the place for dialog buttons and just hide them when in dialog. Then the now free grid space can be for the portraits |
|
Ok. Then we don't really need a new a PortraitWindow either, just a new button for MessageWindow with the player's potrait. Right? Or am I missing something here? |
|
Yeah, the code expects it, so if we provide it, things will just work, otherwise tons of hacks in shared code would be required, which would be bad. There's no problem with overlapping, though we can also cut the region out from the messagewindow. |
|
Lynx how about now? Is this what you were referring to? The size of the small portrait is 38 x 60. I think it might be better if the portraits were on top of the text from the message window. |
|
No, I meant the buttons for the map etc., the fake options window. Then the portraits can be bigger (as if there were only max 4) in their place. |
|
Ok, but then where would the buttons go (map, inventory, center)? |
|
@lynxlynxlynx is this what you mean? Are the buttons for the map, inventory. etc. ok where I placed them at the bottom left?
|
|
Pretty much yeah. :) The portrait buttons can now be bigger. But also the messagewindow needs to be shortened and its bg cut, so things will work as expected on higher resolutions — where the windows otherwise wouldn't overlap perfectly. |
This commit adds the PortraitWindow to the demo, please see #1282