Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Improve custom command dialog #3833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[build] Improve custom command dialog #3833

wants to merge 1 commit into from

Conversation

ntrel
Copy link
Member

@ntrel ntrel commented Apr 12, 2024

Show the command stem in the label.
Use command label for dialog title.

@ntrel
[build] Improve custom command dialog
41620fc 
Show the command stem in the label.
Use command label for dialog title.
@ntrel ntrel added the build-system Related to the build system(s) label Apr 12, 2024
@ntrel ntrel mentioned this pull request Apr 12, 2024
Closed
b4n
b4n approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to work nicely, feels like a clear improvement 👍

@elextr
Copy link
Member

elextr commented Apr 14, 2024

LGBI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4n b4n b4n approved these changes

Assignees
No one assigned
Labels
build-system Related to the build system(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ntrel @elextr @b4n