Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT #1233

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Mar 4, 2023

Modifies build/geanylua.m4:

  • Fixes configure --with-lua-pkg=.... The flag was previously ignored.
  • Falls back on LuaJIT if Lua 5.1 is not available.

When both Lua 5.1 and LuaJIT are installed, LuaJIT can be forced with:

./configure --with-lua-pkg=luajit

Note: Building with LuaJIT requires #1231.

Resolves #1228. Possibly also resolves #1133.

otherwise fallback on Lua 5.1
set with `configure --with-lua-pkg=...`

Options include the basename without extension of files:

   /usr/lib/pkgconfig/lua*.pc

eg, luajit and lua51
@elextr
Copy link
Member

elextr commented Mar 5, 2023

IMO the default should stay lua5.1 for one release to allow packagers to go through the process of changing dependencies. For example I think Debian requires an approval process to change them. Also "somebody" needs to integrate it into the Windows bundle.

We can document that it will change in the release after and as soon as the next release happens we can push the change of default. Of course distros that want to change immediately can just set the CL option to luajit.

@xiota xiota changed the title GeanyLua: Use LuaJIT when available GeanyLua: Use LuaJIT when available, Fix with-lua-pkg configure flag Mar 5, 2023
@xiota xiota changed the title GeanyLua: Use LuaJIT when available, Fix with-lua-pkg configure flag GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT Mar 5, 2023
@xiota
Copy link
Contributor Author

xiota commented Mar 5, 2023

... the default should stay lua5.1...

Done.

We can document that it will change in the release after...

Is that something I should change/add to this PR? The NEWS file?

@elextr
Copy link
Member

elextr commented Mar 5, 2023

Is that something I should change/add to this PR? The NEWS file?

Yeah, its not commonly done, but putting a note in the 1.39 section of the NEWS so its remembered is a good idea.

      The build default will continue to be Lua 5.1 until the next release,
      after which the default will switch to LuaJIT.  To force a specific
      Lua package, configure with the `with-lua-pkg` flag:

          ./configure --with-lua-pkg=luajit
          ./configure --with-lua-pkg=lua51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeanyLua] Switch to LuaJIT? [GeanyLua] For version 5.4.3?
2 participants