Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in progress] Fix gz-sim on Windows #2392

Draft
wants to merge 2 commits into
base: gz-sim8
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

🦟 Bug fix

Fixes #

Summary

This work in progress PR permits to run gz sim on Windows. It is currently in draft, but I opened it to avoid the risk of losing the changes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

traversaro and others added 2 commits April 30, 2024 18:31
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 30, 2024
@traversaro traversaro marked this pull request as draft April 30, 2024 16:36
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.89%. Comparing base (cffd297) to head (4bf5328).
Report is 2 commits behind head on gz-sim8.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2392      +/-   ##
===========================================
- Coverage    65.91%   65.89%   -0.02%     
===========================================
  Files          327      327              
  Lines        31314    31314              
===========================================
- Hits         20641    20635       -6     
- Misses       10673    10679       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

None yet

1 participant