Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause run tutorial #2383

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Apr 25, 2024

📚 Docs

Fixes #2380

Summary

Add a tutorial to start/stop the simulation with either the GUI or CLI. This mirrors the reset simulation tutorial.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ryan Friedman <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 25, 2024
tutorials/pause_run_simulation.md Outdated Show resolved Hide resolved
tutorials/reset_simulation.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.91%. Comparing base (ab18888) to head (7250d24).
Report is 58 commits behind head on gz-sim8.

Current head 7250d24 differs from pull request most recent head 54b25fe

Please upload reports for the commit 54b25fe to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2383      +/-   ##
===========================================
+ Coverage    65.75%   65.91%   +0.16%     
===========================================
  Files          327      327              
  Lines        31233    31313      +80     
===========================================
+ Hits         20537    20640     +103     
+ Misses       10696    10673      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor

azeey commented Jun 10, 2024

@arjo129 Is there anything left for this PR?

tutorials/reset_simulation.md Outdated Show resolved Hide resolved
tutorials/pause_run_simulation.md Show resolved Hide resolved
@azeey azeey enabled auto-merge (squash) June 11, 2024 21:32
@azeey azeey merged commit 5ff44b1 into gazebosim:gz-sim8 Jun 11, 2024
7 of 8 checks passed
@Ryanf55 Ryanf55 deleted the add-pause-run-tutorial branch June 12, 2024 01:07
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Jun 12, 2024

Thanks for the touch ups and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs: Add tutorial on how to start/pause simulator from CLI
3 participants