-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the VPAAndHPAForAPIServer
feature gate for the gardener-operator
#9735
Add the VPAAndHPAForAPIServer
feature gate for the gardener-operator
#9735
Conversation
Skipping CI for Draft Pull Request. |
a4651e6
to
25deeb4
Compare
8391e51
to
656589f
Compare
Hey @ialidzhikov, thanks for the PR! While looking at the changes, I was wondering if we're missing the removal code for HVPA, HPA and VPA objects for the cases when the |
For the kubernetes apiserver component (
For the gardener apiserver ( gardener/pkg/component/gardener/apiserver/apiserver.go Lines 145 to 153 in 876f6f0
Hence, for the gardener apiserver component returning nil from the |
/assign |
/lgtm |
LGTM label has been added. Git tree hash: 3fb2e5501e072f30b500c92d4353875f1e590096
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #9562
A follow-up of #9678
Special notes for your reviewer:
This PR is based on Introduce a new autoscaling mode (The PR is now rebased after the merge of Introduce a new autoscaling mode (VPAAndHPA
) for Shoot Kubernetes API servers #9678, hence it is in draft state until Introduce a new autoscaling mode (VPAAndHPA
) for Shoot Kubernetes API servers #9678 is merged.VPAAndHPA
) for Shoot Kubernetes API servers #9678.Release note: