Velocity FloodGate support

[oldium]

Summary of your change

• Added detection of Velocity proxy usage (i.e. no Bungeecord) in Paper server.
• Added support for FloodGate plugin when using in Velocity plugin (inspired by BungeeCord plugin support).

Verified with:

• Geyser, Velocity+FloodGate+FastLogin proxy and Paper+FastLogin+AdvancedLogin server.
• Velocity+FastLogin and Paper+FastLogin+AdvancedLogin server.

Note: When using Velocity+FloodGate+FastLogin combo behind Geyser, this needs another fix on the FloodGate plugin side. Modern IP forwarding is broken and FloodGate player name is evaluated without a configured Bedrock-player prefix.

Related issue

Related GeyserMC/Floodgate#227

[games647]

Yeah currently the FloodgateAuthTask contains only duplicated code/logic. I'm thinking about a more generic approach. Other than that I'll still need for logic flaws specific to Velocity. However, this shouldn't take long since it's very similar to other platforms.

[games647]

Thanks for separating the commits. I cherry-picked your first commit until we look into the other manner. Thanks for the contribution.

[oldium]

Do you plan to do the refactoring job or do you want me to do something here?

One difference between Bungeecord and Velocity implementation is that the ForceLoginTask is delayed by 1 second (which shown to be actually necessary and was taken from ConnectListener), otherwise they do rather the same job.

[games647]

Do you plan to do the refactoring job or do you want me to do something here?

Originally the plan was that I'll do it in combination with my in-progress session manager changes. However, I didn't have the time yet. Maybe smaller refactoring steps should be better in this case. So refactoring only the floodgate+velocity in this PR would be enough. If you could do it, that would be great.

[xrh0905]

Any update on this?
I'll have to fork the latest branch and merge these changes manually.
It's really painful.

[oldium]

Any update on this? I'll have to fork the latest branch and merge these changes manually. It's really painful.

Sorry, no time for that. But I see that you have started working on it already, so good luck 👍

[bobhenl]

@xrh0905 or @Smart123s don't you have working release that fixes this issue, please?

[xrh0905]

@bobhenl Yeah, I did that, and it's got merged already.

[bobhenl]

@xrh0905 so it's in the released official Dev build already? I've tried it on velocity and it wasn't working, even when I tried to build these two mentioned pull requests from you and @Smart123s , your code worked only for registration but not for auto login for geyser floodgate users. May I done it wrong. Can you provide the working build jar if you have please?

[xrh0905]

@bobhenl Well actually it's been a while since last player join my server with bedrock edition so maybe something is wrong with my code.
Maybe it's a good idea to create a issue for that and we can try to find out where the problem is.

[bobhenl]

@xrh0905 yeah it looks there's definitely something wrong, you can even test it & you'll see that it's not working with velocity. It auto register them, but not auto login.