Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathogen detection from (direct Nanopore) sequencing data using Galaxy - Foodborne Edition, training update 2024 #4952

Merged
merged 9 commits into from
May 29, 2024

Conversation

EngyNasr
Copy link
Contributor

I have updated the training based on the latest update for the used workflow

I kindly ask for a review

@EngyNasr EngyNasr requested a review from a team as a code owner May 20, 2024 18:22
@shiltemann
Copy link
Member

Thanks @EngyNasr! This looks good from my side

shiltemann
shiltemann previously approved these changes May 29, 2024
@EngyNasr
Copy link
Contributor Author

EngyNasr commented May 29, 2024

@shiltemann Thank you soooo much :) , I was pushing some changes to two of the workflows same time, so I made a conflict by mistake, I applied all your changes in the last two pushes but manually to resolve the conflict

@shiltemann
Copy link
Member

shiltemann commented May 29, 2024

@EngyNasr no worries, looks like it all went well with the conflict :)

I've approved it now, feel free to hit merge if it's ready from your side too

@bebatut
Copy link
Member

bebatut commented May 29, 2024

Thanks @EngyNasr for all the changes. I will merge now!

@bebatut bebatut merged commit c61f670 into galaxyproject:main May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants