Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some device have precision problem on ibl brdf #1728

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

https://aone.alipay.com/issue/100905176
https://github.com/galacean/editor/issues/1394

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@zhuxudong zhuxudong added the bug Something isn't working label Sep 4, 2023
@zhuxudong zhuxudong self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (8ac6bc3) 62.88% compared to head (38eb85e) 62.87%.

❗ Current head 38eb85e differs from pull request most recent head 014ec74. Consider uploading reports for the commit 014ec74 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   62.88%   62.87%   -0.02%     
==========================================
  Files         386      386              
  Lines       20001    20001              
  Branches     2856     2856              
==========================================
- Hits        12577    12575       -2     
+ Misses       6297     6296       -1     
- Partials     1127     1130       +3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant