feat(loaders): add 'prefab' option #1601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzhuang
reviewed
Jun 19, 2023
packages/loader/src/resource-deserialize/resources/parser/PrefabParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jun 19, 2023
packages/loader/src/resource-deserialize/resources/scene/SceneParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jun 19, 2023
packages/loader/src/resource-deserialize/resources/parser/PrefabParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jun 19, 2023
packages/loader/src/resource-deserialize/resources/parser/PrefabParser.ts
Outdated
Show resolved
Hide resolved
packages/loader/src/resource-deserialize/resources/parser/PrefabParser.ts
Show resolved
Hide resolved
|
link playground demo |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1601 +/- ##
===============================
===============================
☔ View full report in Codecov by Sentry. |
DaoxingHuang
force-pushed
the
feat_prefab_loader
branch
2 times, most recently
from
4f50594
to
dbd6d02
Compare
LuciferChiu
force-pushed
the
feat_prefab_loader
branch
from
7613816
to
22ee7e7
Compare
luzhuang
reviewed
Jul 31, 2023
luzhuang
reviewed
Jul 31, 2023
packages/loader/src/resource-deserialize/resources/parser/CompositionParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jul 31, 2023
packages/loader/src/resource-deserialize/resources/scene/SceneParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jul 31, 2023
packages/loader/src/resource-deserialize/resources/scene/SceneParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Jul 31, 2023
packages/loader/src/resource-deserialize/resources/scene/SceneParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Aug 2, 2023
| } | ||
| } | ||
|
|
||
| constructor(public readonly context: ParserContext<T, IPrefabFile>) { |
luzhuang
reviewed
Aug 2, 2023
packages/loader/src/resource-deserialize/resources/parser/PrefabParser.ts
Outdated
Show resolved
Hide resolved
luzhuang
reviewed
Aug 2, 2023
packages/loader/src/resource-deserialize/resources/parser/CompositionParser.ts
Outdated
Show resolved
Hide resolved
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: