Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: setup positional audio #1596

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Feat: setup positional audio #1596

wants to merge 6 commits into from

Conversation

JujieX
Copy link
Contributor

@JujieX JujieX commented Jun 12, 2023 •
edited

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

setup positional audio effect

Other information:

Playground: galacean/galacean.github.io#752

@JujieX JujieX added the design engine design label Jun 12, 2023
@JujieX JujieX added this to the 1.2 milestone Jun 12, 2023
@JujieX JujieX self-assigned this Jun 12, 2023
@GuoLei1990 GuoLei1990 marked this pull request as ready for review June 19, 2023 06:15
@GuoLei1990 GuoLei1990 marked this pull request as draft June 19, 2023 06:15
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.1 to main September 15, 2023 09:34
@GuoLei1990 GuoLei1990 added the low priority Low priority issue label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 Awaiting requested review from GuoLei1990

@cptbtptpbcptdtptp cptbtptpbcptdtptp Awaiting requested review from cptbtptpbcptdtptp

At least 2 approving reviews are required to merge this pull request.

Assignees

@JujieX JujieX

Labels
design engine design low priority Low priority issue
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JujieX @GuoLei1990