Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub state machine #1389

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

luzhuang
Copy link
Contributor

@luzhuang luzhuang commented Mar 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added enhancement New feature or request animation Built-in animation system related functions labels Mar 2, 2023
@luzhuang luzhuang added this to the 1.0 milestone Mar 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.43% and project coverage change: +2.64 🎉

Comparison is base (54b48dc) 41.97% compared to head (a174c50) 44.61%.

❗ Current head a174c50 differs from pull request most recent head 4e87cc9. Consider uploading reports for the commit 4e87cc9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1389      +/-   ##
===========================================
+ Coverage    41.97%   44.61%   +2.64%     
===========================================
  Files          350      358       +8     
  Lines        17787    18173     +386     
  Branches      2598     2671      +73     
===========================================
+ Hits          7466     8108     +642     
+ Misses        9629     9281     -348     
- Partials       692      784      +92     
Impacted Files Coverage Δ
...ges/core/src/2d/assembler/SlicedSpriteAssembler.ts 6.75% <0.00%> (+1.27%) ⬆️
packages/core/src/RenderPipeline/RenderPass.ts 70.58% <ø> (ø)
...kages/core/src/RenderPipeline/SpriteMaskManager.ts 28.57% <0.00%> (ø)
packages/core/src/Scene.ts 70.55% <ø> (ø)
...ckages/core/src/animation/AnimatorStatePlayData.ts 13.04% <0.00%> (ø)
packages/core/src/lighting/AmbientLight.ts 26.26% <ø> (ø)
packages/core/src/lighting/DirectLight.ts 84.61% <ø> (+65.38%) ⬆️
packages/core/src/lighting/PointLight.ts 18.51% <ø> (ø)
packages/core/src/lighting/SpotLight.ts 10.20% <ø> (ø)
packages/core/src/material/BlinnPhongMaterial.ts 90.90% <ø> (ø)
... and 56 more

... and 39 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 modified the milestones: 1.0, 1.1 May 18, 2023
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.0 to dev/1.1 May 22, 2023 02:31
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.1 to main September 15, 2023 09:33
@GuoLei1990 GuoLei1990 modified the milestones: 1.1, 1.2 Oct 7, 2023
@GuoLei1990 GuoLei1990 added the high priority High priority issue label Oct 7, 2023
@GuoLei1990 GuoLei1990 removed their assignment Oct 7, 2023
@GuoLei1990 GuoLei1990 self-requested a review October 7, 2023 02:29
@GuoLei1990 GuoLei1990 added medium priority Medium priority issue and removed high priority High priority issue labels Oct 7, 2023
@luzhuang luzhuang modified the milestones: 1.2, Backlog Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions enhancement New feature or request medium priority Medium priority issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants