Babel 7 compatibility

[vjpr]

• Rename all usages for babel-* dependencies with @babel/*
• Remove babel@6 deps and added babel@7 deps
• Fix a scope issue: Feature request: support Babel 7 #184 (comment)

Babel 6 still used for compiling itself.

Not ready for merging, still contains stray commented-out debugging, etc.

[gajus]

Not ready for merging, still contains stray commented-out debugging, etc.

Ping me when it is ready to merge.

[0rvar]

Babel 7 RC has been released

[0rvar]

Babel 7 has been released!

[gajus]

I will be hiding comments that are written with the sole intention of bumping the thread.

Everyone is welcome to contribute to the repository.

@vjpr Has already done a lot of work. I am not up to date with the codebase to judge how much more work needs to be done. If someone is up for taking over from @vjpr, I am happy to assist with the review/ community/ release.

[semireg]

@vjpr, @gajus, I'd like to help test. Hopefully I can be of assistance.

I've forked vjpr's repo and cloned it one directory above my project root. From here, I added the packages using:

yarn add --dev ../flow-runtime/packages/babel-plugin-flow-runtime/
yarn add --dev ../flow-runtime/packages/flow-runtime

Resulting in package.json:

    "@vjpr/babel-plugin-flow-runtime": "../flow-runtime/packages/babel-plugin-flow-runtime/",
    "@vjpr/flow-runtime": "../flow-runtime/packages/flow-runtime",

.babelrc contains:

{
  "presets": ["module:metro-react-native-babel-preset"],
  "env": {
    "production": {
    },
    "development": {
      "plugins": [
        [
          "@vjpr/flow-runtime",
          {
            "assert": true,
            "annotate": true
          }
        ]
      ]
    }
  }
}

When I run "native-react bundle" (see actual command) I receive this error:

index.js: Cannot find module './lib'

Error: Cannot find module './lib'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/Users/devuser/local-dev/rn/RNSemiBoilerplate/node_modules/@vjpr/babel-plugin-flow-runtime/babel-plugin-flow-runtime.js:1:80)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)

Am I going about the installation correctly? Thanks!

[gajus]

I do not expect this branch to work out of the box.

Ensuring that the local tests pass, would the next logical step.

[semireg]

I spent some time working on this.

lerna success run Ran npm script 'test' in packages:
lerna success - babel-plugin-flow-prepack
lerna success - @vjpr/babel-plugin-flow-runtime
lerna success - flow-config-parser
lerna success - flow-runtime-cli
lerna success - flow-runtime-docs
lerna success - flow-runtime-mobx
lerna success - flow-runtime-validators
lerna success - @vjpr/flow-runtime

See https://github.com/semireg/flow-runtime/commits/vjpr/babel-7

TLDR:
• semireg@2d2f6cc
• semireg@701af95
• I moved the two @vjpr packages out of their own namespace so the project would build cleanly.

(Unfortunately, after all this, my actual project still has the same error TypeError: Property value expected type of string but got object. Oh well, progress!)

Fwiw, index.js: Cannot find module './lib' is simply caused by the project not being built.

[jedwards1211]

I can only dedicate so much of my work hours to this, but I'm taking a look now to see what I can contribute. This is definitely starting to become an albatross for my codebase since Babel 6 doesn't support explicit function type parameters, which are required in some cases by Flow >= 0.85.

[jedwards1211]

For anyone trying to contribute to this, my branch is https://github.com/jedwards1211/flow-runtime/tree/jedwards1211/babel-7
So far I've just upgraded the build and test deps in babel-plugin-flow-runtime (including Babel 7)

[jedwards1211]

I've made a PR to @vjpr's fork that fixes the test failures. Working on upgrading the rest of the subpackages to Babel 7 and various other modernizations...

[jedwards1211]

Just encountered this bug while trying to build flow-runtime with Babel 7:
babel/babel#9189

[0rvar]

What's the status on Babel 7 compatibility? Do you need any help? Is @phpnode or @gajus ready to merge this as soon as it's ready?

[gajus]

I am happy to merge this as soon as it is ready.

[jedwards1211]

Okay, I merged these changes in 4f1702b

Will try to release it ASAP

[jedwards1211]

Okay now I just need to get publish permission for the babel-plugin-flow-runtime from @phpnode (he intends for me to have publish permission on everything but it doesn't seem to be configured yet).

[jedwards1211]

Okay everyone, this has been released in v0.18.0! Over the next few days I'll try to work on fixing flow errors in flow-runtime and upgrading other packages to Babel 7.