Introduce a new theme size name for rounded scrollbar corners #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems more like it should be a new theme lookup - scrollbars aren't really a selection type I don't think. |
dweymouth
changed the title
Jacalz
approved these changes
May 18, 2024
andydotxyz
reviewed
May 22, 2024
| @@ -169,6 +169,8 @@ func (t *builtinTheme) Size(s fyne.ThemeSizeName) float32 { | |||
| return 5 | |||
| case SizeNameSelectionRadius: | |||
| return 3 | |||
| case SizeNameScrollBarRadius: | |||
| return 4 | |||
There was a problem hiding this comment.
is 4 right? Should it not match the selection radius or size of the slider bars?
I have not looked at it rendered, but 3 seems right mathematically...
There was a problem hiding this comment.
4 was an arbitrary choice. I can switch it to 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #4360