Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't insert tab character in Entry when Shift+Tab typed #4838

Merged
merged 2 commits into from May 13, 2024
Merged

Don't insert tab character in Entry when Shift+Tab typed #4838

merged 2 commits into from May 13, 2024

Conversation

dweymouth
Copy link
Contributor

Description:

Fixes #4837

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.057% (-0.01%) from 65.07%
when pulling a7d71de on dweymouth:entry-shift-tab
into 54154f9 on fyne-io:develop.

andydotxyz
andydotxyz reviewed May 11, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix thanks, but I think it warrants a test - or is the desktop driver testing not something we've got sorted?

@dweymouth
Copy link
Contributor Author

As far as I can tell we don't have a test desktop driver yet

@dweymouth dweymouth added this to the "Elgin" release, early 2024 milestone May 11, 2024
Jacalz
Jacalz approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding unindenting in the future but this is a nice improvement.

@dweymouth dweymouth merged commit 9a05f40 into fyne-io:develop May 13, 2024
12 checks passed
@dweymouth dweymouth deleted the entry-shift-tab branch May 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz left review comments

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
"Elgin" release, early 2024
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz