Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close deskFile #4789

Closed
wants to merge 1 commit into from
Closed

fix: close deskFile #4789

wants to merge 1 commit into from

Conversation

testwill
Copy link

Description:

close deskFile
Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Check for binary size increases when importing new modules.

@andydotxyz
Copy link
Member

Thanks for the fix - but I wonder if perhaps the close should happen before the tar command runs?

@Jacalz
Copy link
Member

Jacalz commented May 9, 2024

We really should be checking the error when creating that file as well.

Side-note: Should this not be in the fyne-io/tools repo now that we have moved the command line tool?

@testwill
Copy link
Author

We really should be checking the error when creating that file as well.

Side-note: Should this not be in the fyne-io/tools repo now that we have moved the command line tool?

Do you mean to close this PR?

@Jacalz
Copy link
Member

Jacalz commented May 18, 2024

If you could close this PR and open it against https://github.com/fyne-io/tools instead, that would be grand. Sorry for the inconvenience and thanks for your contribution :)

@testwill
Copy link
Author

If you could close this PR and open it against https://github.com/fyne-io/tools instead, that would be grand. Sorry for the inconvenience and thanks for your contribution :)

ok

@testwill testwill closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants