Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for device reboot #7262

Merged
merged 1 commit into from
May 21, 2024
Merged

Wait for device reboot #7262

merged 1 commit into from
May 21, 2024

Conversation

vcdmp
Copy link
Collaborator

@vcdmp vcdmp commented May 15, 2024

Type of pull request:

Wait for device reboot

fwupdtool_output.txt

@vcdmp vcdmp requested review from hughsie and superm1 May 15, 2024 23:07
@@ -500,6 +500,7 @@ fu_logitech_tap_hdmi_device_init(FuLogitechTapHdmiDevice *self)
fu_udev_device_add_flag(FU_UDEV_DEVICE(self), FU_UDEV_DEVICE_FLAG_OPEN_WRITE);
fu_udev_device_add_flag(FU_UDEV_DEVICE(self), FU_UDEV_DEVICE_FLAG_OPEN_NONBLOCK);
fu_udev_device_add_flag(FU_UDEV_DEVICE(self), FU_UDEV_DEVICE_FLAG_IOCTL_RETRY);
fu_device_add_internal_flag(FU_DEVICE(self), FU_DEVICE_INTERNAL_FLAG_REPLUG_MATCH_GUID);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the physical and logical IDs change during flashing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logical ID are NULL for both sub-devices.
Physical ID changes.
From:
DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-1/1-1.2/1-1.2:1.0/video4linux/video2
To:
DEVPATH=/devices/pci0000:00/0000:00:14.0/usb2/2-1/2-1.2/2-1.2:1.0/video4linux/video2

I have added log statements to dump physical/logical in _setup(). Also added log statements to dump other udev attributes. Full log dump attached.

Copy link
Member

@superm1 superm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into two commits. Also; do you want these in 1.9.x?

@vcdmp
Copy link
Collaborator Author

vcdmp commented May 20, 2024

split into two commits. Also; do you want these in 1.9.x?

Split: #7270
Yes for 1.9.x

@vcdmp vcdmp changed the title Wait for device reboot, rename flag to avoid conflict Wait for device reboot May 20, 2024
@vcdmp vcdmp requested review from hughsie and superm1 May 20, 2024 20:19
@superm1
Copy link
Member

superm1 commented May 21, 2024

Can you please rebase on main and force push? No merge commits please.

@superm1
Copy link
Member

superm1 commented May 21, 2024

I see another push with a merge request, but it's not rebased, please try again. You can do it like this:

git rebase -i origin/main
git push --force origin

@vcdmp vcdmp force-pushed the wip/vcdmp/tap-flag-reboot-0 branch from 27ccde1 to c5c5c03 Compare May 21, 2024 16:14
@superm1 superm1 force-pushed the wip/vcdmp/tap-flag-reboot-0 branch from c5c5c03 to 4ba4b7a Compare May 21, 2024 16:37
@superm1 superm1 enabled auto-merge (rebase) May 21, 2024 16:37
@superm1 superm1 disabled auto-merge May 21, 2024 16:50
@superm1 superm1 merged commit 5fdb6eb into main May 21, 2024
18 checks passed
@superm1 superm1 deleted the wip/vcdmp/tap-flag-reboot-0 branch May 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants