ShellClassPathResolver Windows/MinGW/MSYS Support #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now will look for kotlinLspClasspath.bat in project's root (and classpath.bat globally in user's home folder) instead of '.sh' shell executables
fwcd
added
the
dependency resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShellClassPathResolver will now look for kotlinLspClasspath.bat in project's root (and classpath.bat globally in user's home folder) instead of '.sh' shell executables.
JVM will throw
Cannot run program "...\kotlinLspClasspath.sh" (in directory "..."): CreateProcess error=193, %1 is not a valid Win32 applicationexception when executing shell executable on Windows based MSYS/MinGW. I could not find a more elegant way to deal with this except using a separate batch file executable on Windows.This ShellClassPathResolver (@Nycto added this capability in 2019) is somehow hidden in the code base here, I think we need to add a bit of documentation to the main readme file regarding the usage.
And I just noticed @borisbrodski had a PR with the exact same purpose opened last year (with addition of the readme niceties) and I embarrassingly didn't check before going through with this. Sigh ...