Set proxy settings from envars #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic proxy support from environment variables, need to add this option in parameter of patchman cli.
furlongm
reviewed
Apr 12, 2022
| @@ -33,6 +34,11 @@ | |||
| from progressbar import Bar, ETA, Percentage, ProgressBar | |||
| from patchman.signals import error_message | |||
|
|
|||
| http_proxy=getenv('http_proxy') | |||
| proxies = { | |||
There was a problem hiding this comment.
Should https_proxy not come from the https_proxy env var?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic proxy support from environment variables, need to add this option in parameter of patchman cli.