Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add CROSS_NO_WARNINGS: 0 to restore prior cross fallback behaviour #1080

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

fujiapple852
Copy link
Owner

@fujiapple852 fujiapple852 commented Mar 30, 2024

User description

See cross-rs/cross#1447


Type

enhancement


Description


Changes walkthrough

Relevant files
Configuration changes
release.yml
Add CROSS_NO_WARNINGS to GitHub Actions Release Workflow 

.github/workflows/release.yml

  • Added CROSS_NO_WARNINGS: 0 environment variable to the release
    workflow to restore previous cross fallback behavior.
  • +1/-0     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Description updated to latest commit (e9af260)

    Copy link

    PR Review

    🧪 Relevant tests

    No

    🔍 Possible issues

    No

    🔒 Security concerns

    No

    Code feedback:

    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    
    [pr_reviewer]
    some_config1=...
    some_config2=...
    

    See the review usage page for a comprehensive guide on using this tool.

    Copy link

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Maintainability
    Add a comment explaining the purpose of CROSS_NO_WARNINGS: 0.

    Consider adding a comment above the CROSS_NO_WARNINGS: 0 line to explain its purpose and
    why it's set to 0. This will help future maintainers understand the reason behind this
    configuration and its impact on the build process.

    .github/workflows/release.yml [39]

    +# Explanation about why CROSS_NO_WARNINGS is set to 0
     CROSS_NO_WARNINGS: 0
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    
    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    

    See the improve usage page for a comprehensive guide on using this tool.

    @fujiapple852 fujiapple852 merged commit efb96b5 into master Mar 30, 2024
    19 checks passed
    @fujiapple852 fujiapple852 deleted the build-ignore-cross-warnings branch March 30, 2024 03:41
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    1 participant