Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new relics via Relic Editor modal #2157

Closed

Conversation

tiffanynwyeung
Copy link
Contributor

@tiffanynwyeung tiffanynwyeung commented May 20, 2024

Describe your changes

  • Wrap Relic Editor in a modal
  • Create 'Add New' button on Relics page to instead call the editor modal

This PR could be a springboard into transitioning into adding the ability to edit existing relics. Though, maybe I could just be getting ahead of myself here, as we could easily check if the original static editor on the page loads the existing relic properly for editing before throwing in any issues with getting modal state to work?

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented May 20, 2024

[sr-frontend] [Mon May 20 18:33:46 UTC 2024] - Deployed f40c735 to https://genshin-optimizer-prs.github.io/pr/2157/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Mon May 20 18:40:49 UTC 2024] - Deployed 4b85c96 to https://genshin-optimizer-prs.github.io/pr/2157/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue May 21 01:01:56 UTC 2024] - Deployed 9d54124 to https://genshin-optimizer-prs.github.io/pr/2157/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue May 21 18:57:50 UTC 2024] - Deployed ccaea84 to https://genshin-optimizer-prs.github.io/pr/2157/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Fri May 31 03:37:13 UTC 2024] - Deleted deployment

Copy link
Contributor Author

@tiffanynwyeung tiffanynwyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions I had while working on these changes

libs/sr/ui/src/Relic/RelicEditor/RelicEditor.tsx Outdated Show resolved Hide resolved
libs/sr/page-relics/src/index.tsx Show resolved Hide resolved
… relics page

just a working pass at some changes that could end up being useful transition to adding ability to edit existing relics later
@tiffanynwyeung tiffanynwyeung deleted the sro/convert-relic-editor branch May 31, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants