Executable Tokens #174
Merged
Executable Tokens #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33c60bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The code for virtual (such as `HostContainer()`) has been moved into individual tokens, as opposed to hosting logic for these tokens in `ContainerInstance`. This means that we no longer have to check for individual tokens in the container's `.get` code-path, [which has historically been the case.](https://github.com/freshgum-bubbles/typedi/blob/cd4b8437ac14882a0ed4d1964d76e29b32bd1b3e/src/container-instance.class.mts#L331) Instead, logic for these tokens is now moved into special tokens called Executable Tokens. This yields numerous advantages, one of which being that, should a certain special token go unused, its code can safely be removed from a bundle via dead-code elimination. While **this is mostly an internal change**, the concept of Executable Tokens works quite well, and so I'm considering making it part of the public API surface + documentation after further testing.
freshgum-bubbles
force-pushed
the
feat/callable-tokens
branch
from
9e827eb
to
d7b853b
Compare
freshgum-bubbles
force-pushed
the
feat/callable-tokens
branch
2 times, most recently
from
efaf724
to
a6027c5
Compare
Importing from index seems to break things. Probably an import short-circuit.
Remove support for VIRTUAL_IDENTIFIERS and replace it with support for ExecutableTokens instead. These have the exact same use-case, and both are virtual, so this is not a breaking change.
lint-staged...
If this becomes public API, this skeleton page will be useful.
freshgum-bubbles
force-pushed
the
feat/callable-tokens
branch
from
a6027c5
to
c328535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for virtual tokens (such as
HostContainer()) has been moved into individual tokens,as opposed to hosting logic for these tokens in
ContainerInstance.This means that we no longer have to check for individual tokens in the container's
.getcode-path, which has historically been the case.Instead, logic for these tokens is now moved into special tokens called Executable Tokens.
This yields numerous advantages, one of which being that, should a certain special token go
unused, its code can safely be removed from a bundle via dead-code elimination.
While this is mostly an internal change, the concept of Executable Tokens works quite well,
and so I'm considering making it part of the public API surface + documentation after further testing.
Checklist: