Disable eager services by default in ContainerInstance #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshgum-bubbles
force-pushed
the
feature/prevent-side-effects
branch
2 times, most recently
from
76d0a29
to
a8bae44
Compare
Eager services are harder to test, and make application behaviour more brittle. As a result, I do personally discourage using them. Therefore, by default they are now disabled. This will need more testing. Some further remarks below: Eager loading is generally discouraged, as it makes testing harder and makes the application more confusing to work with. For instance, see: [typestack/typedi#380](typestack/typedi#380). Consider an example of a DatabaseService with eager loading enabled. Once imported, database connections and more will immediately start taking place. In many cases, this will be unexpected and will ultimately be an unwanted side effect. Therefore, we place the eager loading functionality behind a toggleable option, which must be enabled prior to any eager loading strategies taking place.
freshgum-bubbles
force-pushed
the
feature/prevent-side-effects
branch
from
a8bae44
to
c3d4f88
Compare
freshgum-bubbles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eager loading is generally discouraged, as it makes testing harder and makes the application more confusing to work with. For instance, see:
typestack/typedi#380.
Consider an example of a DatabaseService with eager loading enabled. Once imported, database connections and more will
immediately start taking place.
In many cases, this will be unexpected and will
ultimately be an unwanted side effect.
Therefore, we place the eager loading functionality behind a toggleable option,
which must be enabled prior to any eager loading
strategies taking place.