Use batch command internally #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-woerner
force-pushed
the
batch_command
branch
5 times, most recently
from
04acbd4
to
7b4a310
Compare
t-woerner
force-pushed
the
batch_command
branch
3 times, most recently
from
d604d80
to
d7ca265
Compare
rjeffman
reviewed
May 13, 2024
| @@ -1399,34 +1410,94 @@ def exception_handler(module, ex, exit_args, one_name): | |||
| if "errors" in argspec.args: | |||
| handlers_user_args["errors"] = _errors | |||
|
|
|||
| debug = 0x10 | |||
| if debug & 0x1: | |||
There was a problem hiding this comment.
What about calling these flags IPA_DBG_CMD_LIST and IPA_DBG_CMD_COUNT and make them class members?
There was a problem hiding this comment.
I added DEBUG_COMMAND_* constants for this.
The method execute_ipa_commands has been extended to handle multi
commands with the batch command.
New constants for execute_ipa_commands debugging:
DEBUG_COMMAND_ALL = 0b1111
DEBUG_COMMAND_LIST = 0b0001
Print the while command list
DEBUG_COMMAND_COUNT = 0b0010
Print the command number
DEBUG_COMMAND_BATCH = 0b0100
Print information about the batch slice size and currently executed
batch slice
New parameters have been added to execute_ipa_commands:
batch: bool
Enable batch command use to speed up processing
batch_slice_size: integer
Maximum mumber of commands processed in a slice with the batch
command
keeponly: list of string
The attributes to keep in the results returned.
Default: None (Keep all)
debug: integer
Enable debug output for the exection using DEBUG_COMMAND_*
Batch mode can be enabled within the module with setting batch to True
for execute_ipa_commands.
Fixes: freeipa#1128 (batch command support)
The use of the batch command is enabled for execute_ipa_commands. Additionally keeponly is set to ["randompassword"] as this is the only parameter that is used from the data returned from the commands.
The use of the batch command is enabled for execute_ipa_commands. Additionally keeponly is set to [] as nothing is used from the data returned from the commands.
The use of the batch command is enabled for execute_ipa_commands. Additionally keeponly is set to [] as nothing is used from the data returned from the commands.
The use of the batch command is enabled for execute_ipa_commands. Additionally keeponly is set to ["randompassword"] as this is the only parameter that is used from the data returned from the commands.
|
Changes look good to me. The pylint failure is being addressed in another PR. I'll merge this PR as soon as checks pass. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPAAnsibleModule: Add support for batch command in execute_ipa_commands
ipauser: Enable batch command use with keeponly
ipaservice: Enable batch command use with keeponly
ipagroup: Enable batch command use with keeponly
ipahost: Enable batch command with keeponly