Support podman in make dev-tor
#7163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
podman-volume
branch
2 times, most recently
from
9ac0808
to
c9448ca
Compare
deeplow
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks for finding this, at the time when I added the onion persistence I guess I did not realize podman was also supported. The solution didn't work for me so I proposed an alternative.
There's also another thing that needs to be provider-agnostic: the make clean.
Unfortunately `podman volume` and `docker volume` are not identical, podman will (sensibly) error if you try to create a volume that already exists unless you pass `--ignore`, which docker doesn't support and is only in podman 4.4+. So we check with `$DOCKER_BIN inspect` first and only create the volume if necessary. And apply the same changes to `make clean` as well. Co-authored-by: deeplow <[email protected]>
|
Thanks for the suggestion, now applied and fixed |
|
Thanks for the fixes. I was reviewing this but got blocked by #7174. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Unfortunately
podman volumeanddocker volumeare not identical, podman will (sensibly) error if you try to create a volume that already exists unless you pass--ignore, which docker doesn't support.So we conditionally add the needed flag depending on which tool we're using.
Testing
make dev-tortwice under docker, make sure it worksmake dev-tortwice under podman, make sure it works (I've done this laready)Deployment
Any special considerations for deployment? n/a, dev only
Checklist