Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude fonts.css from the base stylesheet #136

Merged

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented May 17, 2024

Checklist:

fonts.css references the font files in /assets. This works with the component library itself, but is broken if used in a consumer project as the fonts are not included in the library bundle.

src: url("./assets/fonts/lato/Lato-Light.woff") format("woff");

I'm keeping the fonts.css out of base.css for now, and not export the fonts.css out for consumption. I'll add it back into base.css via #123, to export the stylesheet together with the font files.

@huyenltnguyen huyenltnguyen requested a review from a team as a code owner May 17, 2024 08:16
@Sembauke Sembauke merged commit daaa72a into freeCodeCamp:main May 21, 2024
5 checks passed
@huyenltnguyen huyenltnguyen deleted the fix/exclude-fonts-definition branch May 21, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants