Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): allow additional whitespace in tests #54655

Merged
merged 2 commits into from May 6, 2024

Conversation

katereverie
Copy link
Contributor

@katereverie katereverie commented May 4, 2024

Added an additional whitespace between template literals and the p element in affected tests.

Checklist:

Closes #54654

Added an additional whitespace between template literals and the p element in affected tests.
@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 4, 2024
@katereverie katereverie changed the title Fix testing Fix(curriculum): allow additional whitespace in tests May 4, 2024
I accidentally deleted part of the original tests.
I included it back in the proposed changes.
@huyenltnguyen huyenltnguyen changed the title Fix(curriculum): allow additional whitespace in tests fix(curriculum): allow additional whitespace in tests May 6, 2024
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katereverie Thank you for the PR, the changes look good to me.

Just wanted to add a quick note that only issues labeled with help wanted or first timers only are open for contribution. So next time, please wait for us to triage the issue before opening a PR 🙂

@huyenltnguyen huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 6, 2024
@huyenltnguyen huyenltnguyen merged commit 25eeb14 into freeCodeCamp:main May 6, 2024
22 checks passed
@katereverie
Copy link
Contributor Author

@katereverie Thank you for the PR, the changes look good to me.

Just wanted to add a quick note that only issues labeled with help wanted or first timers only are open for contribution. So next time, please wait for us to triage the issue before opening a PR 🙂

Thanks for your kind reminder.
I'll keep that in mind! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix testing for Step 28 of Building a fCC Authors Page
3 participants