fix(curriculum): prevent passing in case of <img> element not closed #54644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
...-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md
Outdated
Show resolved
Hide resolved
...-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md
Outdated
Show resolved
Hide resolved
huyenltnguyen
added
the
status: waiting update
…n-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md Co-authored-by: Huyen Nguyen <[email protected]>
…n-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md Co-authored-by: Huyen Nguyen <[email protected]>
huyenltnguyen
approved these changes
May 6, 2024
huyenltnguyen
added
status: waiting review
Dario-DC
requested changes
May 6, 2024
There was a problem hiding this comment.
I've just realized that it doesn't take into account single quotes. Should we allow them? @huyenltnguyen
|
@Dario-DC That's a good catch! I was focusing on the @zxc-w Would you mind updating the regex to allow single quotes? (It's okay if you don't want to make further changes, we are happy to help with that, since this is a slight scope creep 🙂) |
huyenltnguyen
added
status: waiting update
|
@huyenltnguyen sure, I was just waiting to see if I should update it or not. |
Dario-DC
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #54642