Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve username validation test #54634

Merged
merged 3 commits into from May 14, 2024
Merged

feat: improve username validation test #54634

merged 3 commits into from May 14, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 3, 2024 •
edited

  • feat: improve username validation tests
  • feat: improve username validation tests

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 3, 2024
@Sembauke Sembauke marked this pull request as ready for review May 3, 2024 07:25
@Sembauke Sembauke requested a review from a team as a code owner May 3, 2024 07:25
naomi-lgbt
naomi-lgbt reviewed May 3, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the test case for trying to change my username to my current username?

@Sembauke
Copy link
Member Author

Sembauke commented May 4, 2024

That must have fallen through the cracks, feel free to add it in 😄

@huyenltnguyen huyenltnguyen self-assigned this May 14, 2024
@huyenltnguyen huyenltnguyen merged commit 0bf41ec into freeCodeCamp:main May 14, 2024
22 checks passed
@huyenltnguyen huyenltnguyen mentioned this pull request May 14, 2024
Open
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees

@huyenltnguyen huyenltnguyen

Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sembauke @huyenltnguyen @naomi-lgbt