Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): fix tests for step 43 of shopping cart project #54631

Merged
merged 1 commit into from May 7, 2024
Merged

fix(curriculum): fix tests for step 43 of shopping cart project #54631

merged 1 commit into from May 7, 2024

Conversation

praizjosh
Copy link
Contributor

Checklist:

Closes #54598

Modified the regex check to accept either 'item.price + total' or 'total + item.price' to pass the test.

I've tested it locally and it works fine.

regex-0

regex-1

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 3, 2024
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new javascript course These are for issues dealing with the new JS curriculum labels May 6, 2024
JoyShaheb
JoyShaheb approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my end very well, good work !

@JoyShaheb JoyShaheb merged commit 8f9913d into freeCodeCamp:main May 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoyShaheb JoyShaheb JoyShaheb approved these changes

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests for step 43 of shopping cart project
3 participants
@praizjosh @JoyShaheb @jdwilkin4