Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): replace flaky solution #54616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gikf
Copy link
Member

@gikf gikf commented May 2, 2024

Checklist:

Closes #53140


  • Changes solution to one using Markov chain.
  • Improves solution result consistency and efficiency (I'm seeing 4x-25x speedup depending on test case).
  • Don't hesitate to ask if something isn't clear. I can't promise I will be able to explain all the math behind it, but what's happening - yes.

@gikf gikf added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels May 2, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❓🙃 🎉

Did you write this @gikf?

@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 16, 2024
@gikf
Copy link
Member Author

gikf commented May 17, 2024

@moT01,

Yeah, any concerns?

@moT01
Copy link
Member

moT01 commented May 17, 2024

nope. It just looks impressive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test in Project Euler Problem 84
2 participants