Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test passes even though the syntax is not correct | Cat Photo App step-8 #54642

Closed
zxc-w opened this issue May 3, 2024 · 2 comments · Fixed by #54644
Closed

The test passes even though the syntax is not correct | Cat Photo App step-8 #54642

zxc-w opened this issue May 3, 2024 · 2 comments · Fixed by #54644
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@zxc-w
Copy link
Contributor

zxc-w commented May 3, 2024

Describe the Issue

the challenge is to add src attribute to <img> element.

you will pass with this solution:

<img src = "https://cdn.freecodecamp.org/curriculum/cat-photo-app/relaxing-cat.jpg"

which is missing the closing angel bracket >.

tried it from a camper topic at the forum here: Forum

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-html-by-building-a-cat-photo-app/step-8

Your code

<img src="https://cdn.freecodecamp.org/curriculum/cat-photo-app/relaxing-cat.jpg"

This should not pass

Expected behavior

A hint message appears, preventing the camper from passing.

Screenshots

No response

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response

@zxc-w zxc-w added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels May 3, 2024
@Endekalu-Zemenu
Copy link

Endekalu-Zemenu commented May 3, 2024

can i work on this #54642?

@huyenltnguyen
Copy link
Member

@zxc-w Thank you for reporting the issue.

We will need to add a test case to the challenge to check for the /> ending.


This issue is open for contribution. The file that you should be updating is https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/14-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md.

Please make sure you read our guidelines for contributing as well as our expectations from a pull request, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.

Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

@huyenltnguyen huyenltnguyen added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
3 participants