Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animations when using jQuery >= 1.7.2 and jQuery UI #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RobCherry
Copy link

Fixes #61 #86 #87 and #106

@quietasice
Copy link

jQuery 1.8.3 and jQuery ui 1.9.2 animation didn't work :(

@DonDi1989
Copy link

Also it doesn't work with jQuery UI 1.10.3. Is there any solution ?

@jonaslu
Copy link

jonaslu commented Oct 31, 2013

I got it working with jQuery UI 1.10.3:

First, apply the fix reply #95 in so the "focus" event fires again reply 3 by @jellever

Then change the following 3 lines (line 693 - 697 in version https://github.com/fredhq/roundabout/blob/d8cc98ccc0e214514cfe76fe4c1a9d8a99a50c6b/jquery.roundabout.js)

if (true) {
  newBearing = passedData.start + ((bearing - passedData.start) * newBearing);
}

// newBearing = methods.normalize.apply(null, [newBearing]);

The newBearing was set to 0 with without these changes. Did this for a quick workaround - it requires more digging to fix the root cause.

@kitsunde
Copy link

kitsunde commented Feb 6, 2014

@jonaslu Just ran into this and that hack works great, thanks. :)

@JorisLambrechts
Copy link

@jonaslu thanks, it worked (even without the fix in #95)
I'm using jquery 1.10.1 and jquery UI 1.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery 1.7.2, jQuery UI 1.8.23 AND roundabout 2.4.2 animation still broken
6 participants