In FF! keep one character more when truncating then in Ladybug #6762
Conversation
philipsens
changed the title
|
Ik zie een bot melding over code coverage. Als deze code wordt gemerged, dan kan ik later zorgen voor een integratie test in ladybug-ff-cypress-test. Is dit de moeite waard en heeft het prioriteit? |
|
Als de ladybug maxSize +1 krijgt dan weet de ladybug toch niet hoe groot het bericht was? Ik zie in het plaats '55 characters removed' staan. Ik neem aan dat dat dan altijd '1 characters removed' zal worden? |
| // Both Ladybug and the present class in the Frank!Framework | ||
| // truncate messages as configured through maxMessageLength. | ||
| // In this class we keep one character more such that | ||
| // Ladybug can detect when a message is being truncated. |
There was a problem hiding this comment.
Can you add to the comment something like the following?
and show a message to the user that the message has been truncated
| // Both Ladybug and the present class in the Frank!Framework | ||
| // truncate messages as configured through maxMessageLength. | ||
| // In this class we keep one character more such that | ||
| // Ladybug can detect when a message is being truncated. |
There was a problem hiding this comment.
It would be nice to not duplicate the comment in two classes. A possible solution would be to add something like the following with the comment to one of the classes and use this var in both classes:
protected static final long MAX_MESSAGE_LENGTH_ADJUSTMENT = 1L;
| // In this class we keep one character more such that | ||
| // Ladybug can detect when a message is being truncated. | ||
| private int truncateMessageToLength = -1; | ||
|
|
There was a problem hiding this comment.
Instead of this extra var and method you could do "maxMessageLengt + MAX_MESSAGE_LENGTH_ADJUSTMENT" where you now used truncateMessageToLength (not sure what would be the best solution)
|
Sorry, I see now that I did not test correctly earlier. See picture below:
Earlier I checked the input message of the adapter, which is the filename. That one showed a reasonable value for the number of truncated characters. But I had to look at the output, the result of reading the file. That one shows that one only one character is truncated. It turns out that this fix does not work. |
|
Both the Frank!Framework's ladybug module and ladybug itself truncate messages when they are too long. Because the F!F does the truncation first, Ladybug does not see that truncation was necessary. Because of this, Ladybug did not report that a report message was truncated.
This PR lets the F!F keep one extra character such that Ladybug does reduce the message size when truncation is needed. With this PR, the old Ladybug GUI does show it when truncation has been done:
The new Ladybug GUI does not show truncation even with the present PR included in the F!F, see: