Skip to content

Commit

Permalink
chore(pdc-frontend): improve the searchbar accessibility
Browse files Browse the repository at this point in the history
  • Loading branch information
AliKdhim87 authored and Robbert committed May 6, 2024
1 parent 426913d commit 7d1e98f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ const RootLayout = async ({ children, params: { locale } }: LayoutProps) => {
onSearchSubmit={onSearchSubmitAction}
onSearchChange={getLiveSuggestions}
submitButtonText={t('search-bar.search-submit')}
inputAriaLabel={t('search-bar.input-ariaLabel')}
suggestionsTitle={t('search-bar.suggestions-title')}
hitsTitle={t('search-bar.hits-title')}
/>
Expand Down
1 change: 0 additions & 1 deletion apps/pdc-frontend/src/app/[locale]/(rootLayout)/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ const RootLayout = async ({ children, params: { locale } }: LayoutProps) => {
onSearchSubmit={onSearchSubmitAction}
onSearchChange={getLiveSuggestions}
submitButtonText={t('search-bar.search-submit')}
inputAriaLabel={t('search-bar.input-ariaLabel')}
suggestionsTitle={t('search-bar.suggestions-title')}
hitsTitle={t('search-bar.hits-title')}
/>
Expand Down
1 change: 0 additions & 1 deletion apps/pdc-frontend/src/app/i18n/locales/en/layout.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"search-bar": {
"search-submit": "Search",
"input-ariaLabel": "search terms",
"suggestions-title": "Do you mean:",
"hits-title": "Go straight to:"
},
Expand Down
1 change: 0 additions & 1 deletion apps/pdc-frontend/src/app/i18n/locales/nl/layout.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"search-bar": {
"search-submit": "Zoeken",
"input-ariaLabel": "zoektermen",
"suggestions-title": "Bedoelt u:",
"hits-title": "Meteen naar:"
},
Expand Down
3 changes: 0 additions & 3 deletions apps/pdc-frontend/src/components/SearchBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export interface SearchBarProps {
suggestedHits?: SuggestedHits[];
suggestions?: Suggestions[];
submitButtonText: string;
inputAriaLabel: string;
suggestionsTitle: string;
hitsTitle: string;
locale: string;
Expand All @@ -31,7 +30,6 @@ export const SearchBar: React.FC<SearchBarProps> = ({
onSearchSubmit,
onSearchChange,
submitButtonText,
inputAriaLabel,
suggestionsTitle,
hitsTitle,
locale,
Expand Down Expand Up @@ -83,7 +81,6 @@ export const SearchBar: React.FC<SearchBarProps> = ({
items={optimisticSearchValue.value}
input={{
id: 'search-input',
ariaLabel: inputAriaLabel,
name: 'search',
required: true,
}}
Expand Down

0 comments on commit 7d1e98f

Please sign in to comment.