Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): selectively enable Etherscan trace resolving when a test in ran in a forked environment and return block number in trace on a failed test #7606

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

fix(forge): selectively enable Etherscan trace resolving when a test in ran in a forked environment and return block number in trace on a failed test #7606

wants to merge 52 commits into from

Commits on Apr 8, 2024

  1. add has_forks to backend

    @zerosnacks
    zerosnacks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    68bfdb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into zerosnacks/fix-tracing-regression

    @zerosnacks
    zerosnacks committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7251ef4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. pass down environment, add dynamic enabled / disabled flag on a per t… 

    …est basis for whether we need to resolve via Etherscan or not
    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5eca07c View commit details
    Browse the repository at this point in the history

  2. add clarifying comment

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    004dc11 View commit details
    Browse the repository at this point in the history

  3. check has_forks at test runtime

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    46ae039 View commit details
    Browse the repository at this point in the history

  4. pass down block number

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    acba4c4 View commit details
    Browse the repository at this point in the history

  5. fix build issues, cast block number as u64

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f3fc621 View commit details
    Browse the repository at this point in the history

  6. flip order

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d63e4fc View commit details
    Browse the repository at this point in the history

  7. clarify

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0ff4a3f View commit details
    Browse the repository at this point in the history

  8. remove unused code

    @zerosnacks
    zerosnacks committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c42c3a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'master' into zerosnacks/fix-tracing-regression

    @zerosnacks
    zerosnacks committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f9ad7c0 View commit details
    Browse the repository at this point in the history

  2. simplify by making enable_etherscan flip based on parameter yes

    @zerosnacks
    zerosnacks committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c5a4690 View commit details
    Browse the repository at this point in the history

  3. add environment report formatter, add block on failure

    @zerosnacks
    zerosnacks committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    15a9bfd View commit details
    Browse the repository at this point in the history

  4. add block format to test, looks incorrect, especially in the USDTCall… 

    …ingTest
    @zerosnacks
    zerosnacks committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7e4bb99 View commit details
    Browse the repository at this point in the history

  5. fix, has_forks was inverted

    @zerosnacks
    zerosnacks committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c473f01 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'master' into zerosnacks/fix-tracing-regression

    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7f1f3c2 View commit details
    Browse the repository at this point in the history

  2. to be able to capture forking state inside of calls (as in vm.createS… 

    …electFork inside of a function) we need to capture the environment
    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    efc05d3 View commit details
    Browse the repository at this point in the history

  3. filter out block number at genesis, assume non-forked environment in … 

    …that case
    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d2ba46b View commit details
    Browse the repository at this point in the history

  4. add basic tests cases

    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5ae23e5 View commit details
    Browse the repository at this point in the history

  5. simplify has_forks check, we can simply check `issued_local_forks_ids… 

    …` (is_empty)
    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4edb749 View commit details
    Browse the repository at this point in the history

  6. add specific test for verbose tracing and non verbose tracing for bot… 

    …h successful and failing tests
    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8fb7445 View commit details
    Browse the repository at this point in the history

  7. revert simplification

    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    676b249 View commit details
    Browse the repository at this point in the history

  8. add note

    @zerosnacks
    zerosnacks committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d48c3b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. pull in latest master

    @zerosnacks
    zerosnacks committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b48a587 View commit details
    Browse the repository at this point in the history

  2. revert repro_6531, clean up comments

    @zerosnacks
    zerosnacks committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5404c5c View commit details
    Browse the repository at this point in the history

  3. make sure to output block number in both test results as well as the … 

    …failure report
    @zerosnacks
    zerosnacks committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    059decc View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'master' into zerosnacks/fix-tracing-regression

    @zerosnacks
    zerosnacks committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5799cc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. merge in master

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07dde75 View commit details
    Browse the repository at this point in the history

  2. remove env passing, to implement an alternative, move etherscan toggl… 

    …e out of loop
    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07fceb5 View commit details
    Browse the repository at this point in the history

  3. add context capturing, collecting all block changes during execution

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bfca63c View commit details
    Browse the repository at this point in the history

  4. fix overflow

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    85bb139 View commit details
    Browse the repository at this point in the history

  5. fix clippy

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    39807c9 View commit details
    Browse the repository at this point in the history

  6. add test trace for multiblock fork

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    56e1006 View commit details
    Browse the repository at this point in the history

  7. fix title

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    52e2ca5 View commit details
    Browse the repository at this point in the history

  8. add context tracking to setup

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    28986ac View commit details
    Browse the repository at this point in the history

  9. add context tracking support for fuzz and invariant counter example c… 

    …ases
    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ad74f98 View commit details
    Browse the repository at this point in the history

  10. enhance with context, move definition to core

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4fcbdce View commit details
    Browse the repository at this point in the history

  11. re-add environment with context

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a2ba880 View commit details
    Browse the repository at this point in the history

  12. fix clippy

    @zerosnacks
    zerosnacks committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dd2592b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'master' into zerosnacks/fix-tracing-regression

    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    715d8b2 View commit details
    Browse the repository at this point in the history

  2. appears formatting issue could relate to diff error throw

    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f6310ff View commit details
    Browse the repository at this point in the history

  3. update trace

    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    00897fa View commit details
    Browse the repository at this point in the history

  4. add fuzz test case, also logs block correctly - avoid pushing genesis… 

    … block contexts to avoid unnecessary tracking overhead
    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    163e337 View commit details
    Browse the repository at this point in the history

  5. remove debug trace

    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e5037d1 View commit details
    Browse the repository at this point in the history

  6. improve documentation

    @zerosnacks
    zerosnacks committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2b6865f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. pull in master

    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b311550 View commit details
    Browse the repository at this point in the history

  2. only rely on context tracing to determine fork status

    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1536799 View commit details
    Browse the repository at this point in the history

  3. remove context as inspector, simply inline

    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    af34ff8 View commit details
    Browse the repository at this point in the history

  4. remove inspector, only rely on executor env block number at the end o… 

    …f the raw call
    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d42eb2e View commit details
    Browse the repository at this point in the history

  5. re-add inspector - cleaner than inlining and allows capture of transf… 

    …orming block env that gets overwritten in the backend, if not implemented as an inspector we would not be able to capture the modifications made by cheatcodes
    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2e5918b View commit details
    Browse the repository at this point in the history

  6. add comment on block number modification due to cheat codes

    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c0775aa View commit details
    Browse the repository at this point in the history

  7. remove wrongly merged funcs file, avoid formatting diff

    @zerosnacks
    zerosnacks committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    747e17c View commit details
    Browse the repository at this point in the history