Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MULTIPLE-API-CALLS) merge multiple upload-api calls into one #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Aug 10, 2022

Signed-off-by: dushimsam [email protected]

Description

Merge the create upload API and create job API into one API request.

Changes

  1. Removed the getUploadApiRequest.
  2. Removed the createJobApiRequest.
  3. Added scanOptions parameter on the uploadApiRequest.

How to test

How to test

1. Upload Request

Fill up the input details on Vcs Upload Page for the upload click the upload button
hence the request should look as follows.

merge_uploads_request

merge_uploads

2. Response

You should see this response object with the ID of the corresponding job in the message.

merge_uploads_response

Related issue

closes : Shruti3004/FOSSology-REST-API#2 ,#260

cc: @shaheemazmalmmd @GMishx

@@ -44,11 +42,9 @@ import {

// Helper function for error handling
import { handleError } from "shared/helper";
import messages from "../../../constants/messages";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can directly be imported like:
import messages from "constants/messages";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure , thanks

@Shruti3004
Copy link
Collaborator

@dushimsam can you also fix test cases

@dushimsam
Copy link
Contributor Author

ok , I'm on it.

@dushimsam dushimsam force-pushed the dushimsam/fix/upload/multiple-calls branch from 9c5c27b to 3e1f574 Compare August 12, 2022 03:44
@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 12, 2022

tested and working perfectly.

@shaheemazmalmmd shaheemazmalmmd added needs review Need code review needs test Needs testing labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Need code review needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API: Created the single request for the upload and analysis
3 participants